The prediction of deformation capacity of reinforced concrete (RC) columns is the foundation to realize performance-based seismic design. This paper presented a critical review of flexural-shear failure of columns based on Chinese design codes. The empirical formulas of ultimate deformation of RC columns were discussed, and the deficiencies of parametric model were revealed. The failure mode of flexural-shear, shear behavior and P-Δ effect are the main reasons for the scattering of the prediction of ultimate displacement. The length of plastic hinge is not a specific statistical sample. The prediction of ultimate displacement on the basis of equivalent plastic hinges method shows large scatter. In order to reveal the real shear demand in RC columns subjected to seismic loadings, the interaction between shear and flexural behaviors in plastic hinge zone should be taken into consideration. However, the corresponding simplified methods need to be improved. An effective method to evaluate the effect of shear on the deformation performance of columns is not available. In the GB 50010—2010 ‘Code for design of concrete structures’, the correction of the shear capacity formula for seismic design can effectively avoid the shear failure of columns under large displacement reversals, but the safety margin is different under varying ductility levels of ultimate displacement. The scatter of the prediction of GB 50010—2010 is larger than that of the original formula. Shear demand of identical columns under different test setups is not same due to the variety of P-Δ effect. The influence of P-Δ effect on the ultimate deformation capacity of RC columns depends failure modes. Finally, according to the relevant research in ultimate deformation, it is suggested that Chinese building code should be supplemented with an empirical formula for lower limit value of ultimate displacement by regression methods to improve performance-based design methods. [ABSTRACT FROM AUTHOR]